Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI 전체적으로 업데이트 #287

Merged
merged 8 commits into from
Dec 1, 2023
Merged

UI 전체적으로 업데이트 #287

merged 8 commits into from
Dec 1, 2023

Conversation

jisung24
Copy link
Contributor

@jisung24 jisung24 commented Dec 1, 2023 •
edited
Loading

내용 설명

  • 지도 페이지 div제거
  • 학원 좋아요 상세페이지 학원 명 길면 ...처리
  • 마이페이지 세로로 나오는 문제 해결
  • 로그인 무한루프 제거
  • 찜한 학원이 1개도 없을 때 멘트 추가

스크린샷?

지도 div 제거

image

학원 명 길면 ...처리

image

마이 페이지 아이 세로로 나오는 문제

image

멘트 추가

image

close #275

@jisung24 jisung24 added the bug Something isn't working label Dec 1, 2023
@jisung24 jisung24 self-assigned this Dec 1, 2023
@jisung24 jisung24 linked an issue Dec 1, 2023 that may be closed by this pull request
🐞 [Bug] UI %에 맞게 수정 #275
Closed
@jisung24 jisung24 changed the base branch from main to dev December 1, 2023 08:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀storybook: https://6538ad4ed98b5215f122ca23-rzsazzbimv.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀storybook: https://6538ad4ed98b5215f122ca23-ockcufzpvm.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

🚀storybook: https://6538ad4ed98b5215f122ca23-ncnpjmpaor.chromatic.com/

HeeSeok-kim
HeeSeok-kim approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@HeeSeok-kim HeeSeok-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@HeeSeok-kim HeeSeok-kim merged commit 96be610 into dev Dec 1, 2023
2 of 3 checks passed
@jisung24 jisung24 deleted the bug/275-ui-update branch December 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeeSeok-kim HeeSeok-kim HeeSeok-kim approved these changes

Assignees

@jisung24 jisung24

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 [Bug] UI %에 맞게 수정
2 participants
@jisung24 @HeeSeok-kim